Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indent setting in .editorconfig for *.v files #183

Merged
merged 3 commits into from
Oct 22, 2023

Conversation

ttytm
Copy link
Member

@ttytm ttytm commented Oct 22, 2023

Updates a aged setting in the .editorconfig for V files.

I'm running into some editor interference with the current indent setting. If the current setting would actually be used it would also be incompatible with v fmt.

Summary by CodeRabbit

  • Style: Updated the code formatting rules. Files with extensions .v, .vsh, and .mod will now use tab-based indentation instead of space-based. This change ensures consistency in code style across these file types.
  • Chore: Introduced a new rule to automatically remove trailing whitespace in all files, enhancing the cleanliness and readability of the codebase.

Please note, these changes are internal and do not affect the functionality or user experience of the software.

@coderabbitai
Copy link

coderabbitai bot commented Oct 22, 2023

Walkthrough

This pull request primarily focuses on modifying the EditorConfig file to enhance code formatting. The changes include switching the indentation style from spaces to tabs for files with extensions .v, .vsh, and .mod, and adding a rule to trim trailing whitespace in all files.

Changes

File Summary
.editorconfig The indentation style for files with .v, .vsh, and .mod extensions has been changed from spaces to tabs. A rule to trim trailing whitespace in all files has been added.

🐇

In the land of code, where the shadows lie,

Tabs replace spaces, under the EditorConfig sky.

Trailing whitespaces, we bid you goodbye,

For in this realm of brackets, clean code must comply! 🎉


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.

Note: For conversation with the bot, please use the review comments on code diffs or files.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Commits Files that changed from the base of the PR and between 904b61d and 18ee3f6.
Files selected for processing (1)
  • .editorconfig (1 hunks)
Files skipped from review due to trivial changes (1)
  • .editorconfig

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Commits Files that changed from the base of the PR and between 18ee3f6 and ea4b877.
Files ignored due to filter (6)
  • fft/v.mod
  • inout/h5/v.mod
  • mpi/v.mod
  • plot/v.mod
  • v.mod
  • vcl/v.mod
Files selected for processing (1)
  • .editorconfig (1 hunks)
Files skipped from review due to trivial changes (1)
  • .editorconfig

Copy link
Member

@ulises-jeremias ulises-jeremias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@ulises-jeremias ulises-jeremias merged commit 0279180 into vlang:main Oct 22, 2023
9 checks passed
@ttytm ttytm deleted the fix/editorconfig-indent-setting branch October 24, 2023 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants