Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] VPM should not allow submitting modules which are actually private repos. #103

Open
omegaui opened this issue May 15, 2023 · 1 comment

Comments

@omegaui
Copy link

omegaui commented May 15, 2023

Describe the bug

I have seen many times,
When I search, select and try to download a module from the list in vpm modules website.
Git asks me for username and password, which clearly means that the repo added to the vpm list is a private repo.
VPM shouldn't allow that to any user.

Expected Behavior

VPM Site should not allow adding modules with private repos.

Current Behavior

VPM Site currently allows adding modules with private repos.

Reproduction Steps

I think its now clear what I meant to say.
heres the example:
image

Possible Solution

No response

Additional Information/Context

No response

V version

latest version

Environment details (OS name and version, etc.)

Its arising due to missing repository validations on the vpm.modules.io/ during submission of a module.

@xy3
Copy link
Contributor

xy3 commented May 19, 2023

There is already a check in place to disallow users submitting private repositories.

Maybe the issue is for packages that were submitted before that check was implemented, or packages that users have made private some time after they submitted it.

Either way, the fix should be to have automated checking periodically to verify the status of the packages already listed on vpm. I.e. periodically remove packages that return a 404 status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants