Non-string map keys

[medvednikov]

No description provided.

[ntrel]

I'm interested in working on this, anyone else? I think the key type would need a hash method and* an equals function. (For autofree also an optional clone method).

* actually the general-purpose hash is probably enough.

[medvednikov]

@ntrel good luck!

@ka-weihe can give some hints and answer questions about the implementation.

[ka-weihe]

@ka-weihe can give some hints and answer questions about the implementation.

For sure. @ntrel feel free to contact me on discord (I'm "Kasper W" on V's discord).

[dumblob]

Beware non-string maps will amplify the undefined behavior of equals() for floats.

[ntrel]

I'm working on making DenseArray support non-string keys first, with map still using string keys. When that's done I can make a pull request.

I've spoken to @ka-weihe on Discord and he suggested a good optimization when there are no deleted keys, so my work will be compatible with that.

[dumblob]

I've spoken to @ka-weihe on Discord and he suggested a good optimization when there are no deleted keys, so my work will be compatible with that.

Speaking of optimization, the check for existence in a "static" map (if x in mymap_with_just_unconditional_values_added) or array (if x in [ 'a', 'b', 'c' ]) can be "extremely" optimized by using optimal hashing.

[ka-weihe]

@dumblob that is correct and I think we will eventually do that optimization along with a huge list of other optimizations, but right now the focus is strictly on non-string keys 🙂

[ntrel]

DenseArray is now string-free. I'm working on encapsulating the other operations on a key with functions taking voidptr.

[danieldaeschle]

This has been implemented afaik