Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

analyzer: use latest install script when updating #81

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

ttytm
Copy link
Member

@ttytm ttytm commented Apr 1, 2024

Fixes #11

If there were installs from the prior v-analyzer repo running v-analyzer up can currently cause several issues.

For a reproduction, put the install script of the old repo into v-analyzers (old install script: https://github.com/v-analyzer/v-analyzer/blob/main/install.vsh) config dir (e.g. ~/.config/v-analyzer/install.vsh). That's the location that v-analyzer is currently looking for a script and it won't fetch a fresh script when it finds it.
Then running v-analzyer up - even with the latest nightly version - It will "update" / "downgrade" to the latest release of the old repo.

To fix this, and to also get advantages of potential fixes and updates to the install script now will always fetch the latest install script for an installation of a release or nightly version.

The fix will work after using a new binary that contains the changes in this PR.

@ttytm ttytm merged commit 95869fa into vlang:main Apr 1, 2024
12 checks passed
@ttytm ttytm deleted the analyer/fix-up branch April 1, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v-analyzer up doesn't write the new binary
1 participant