Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tree_sitter] Update tree-sitter-cli version to 0.22.2 #41

Merged
merged 5 commits into from
Mar 21, 2024
Merged

[tree_sitter] Update tree-sitter-cli version to 0.22.2 #41

merged 5 commits into from
Mar 21, 2024

Conversation

Lycs-D
Copy link
Contributor

@Lycs-D Lycs-D commented Mar 18, 2024

No description provided.

@Lycs-D Lycs-D changed the title [tree_sitter] Update tree_sitter-cli version to 0.22.2 [tree_sitter] Update tree-sitter-cli version to 0.22.2 Mar 18, 2024
@Lycs-D Lycs-D mentioned this pull request Mar 18, 2024
Merged
ttytm
ttytm reviewed Mar 20, 2024
View reviewed changes
Copy link
Member

@ttytm ttytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work 👍 I'd merge when the comments are addressed.

tree_sitter_v/.gitignore Outdated Show resolved Hide resolved
tree_sitter_v/bindings.v Outdated Show resolved Hide resolved
tree_sitter_v/bindings/c/tree-sitter-v.h Outdated Show resolved Hide resolved
@ttytm ttytm added this to the 0.0.5 milestone Mar 20, 2024
@Lycs-D Lycs-D marked this pull request as draft March 20, 2024 19:19
@Lycs-D Lycs-D marked this pull request as ready for review March 20, 2024 20:35
@ttytm
Copy link
Member

ttytm commented Mar 20, 2024

I'll push a commit that addresses the comments about the bindings location which is a little simplification to the update and should produce less conflicts with other branches. Please tell if there are any concerns. We can still work with it 👍

@ttytm ttytm merged commit 366d30c into vlang:main Mar 21, 2024
13 checks passed
@Lycs-D Lycs-D deleted the update_tree_sitter branch March 21, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttytm ttytm ttytm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.0.5
Development

Successfully merging this pull request may close these issues.
2 participants
@Lycs-D @ttytm