Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hanging on windows #130

Merged
merged 8 commits into from
Oct 8, 2024
Merged

fix hanging on windows #130

merged 8 commits into from
Oct 8, 2024

Conversation

phcreery
Copy link
Contributor

@phcreery phcreery commented Sep 28, 2024

fix #128
vfmt on large files fills the stdout output buffer but v-analyzer does not read the buffer until vfmt exits.

// test_file := 'file:///c%3A/Users/phcre/Documents/v/imageeditor/testing/proc.v'
dump(test_file)

src := os.read_file(test_file) or { panic('Cannot read file') }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

os.read_file handles relative and absolute paths, like the ones returned by os.real_path .

@phcreery phcreery marked this pull request as ready for review October 2, 2024 14:51
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman spytheman merged commit ea53875 into vlang:main Oct 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v-analyzer hang or closes on windows
2 participants