Add cBPF ops support to BpfFilter #909
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stffabi
force-pushed
the
feature/bpf-filter-ops
branch
from
479949c
to
4f2580e
Compare
aboch
reviewed
Jul 3, 2024
| @@ -1039,3 +1066,42 @@ func SerializeRtab(rtab [256]uint32) []byte { | |||
| _ = binary.Write(&w, native, rtab) | |||
| return w.Bytes() | |||
| } | |||
|
|
|||
| func deserializeSockFilter(opsLen uint16, ops []byte) ([]SockFilter, error) { | |||
| if excp := int(opsLen) * 8; len(ops) != excp { | |||
There was a problem hiding this comment.
Why do we need to define this excp inside this if?
I do not think it gives us much compared to
if len(ops) != 8*opsLen {
[...]", len(ops), 8*opsLen)
}
aboch
reviewed
Jul 3, 2024
| Jf: ops[3], | ||
| K: native.Uint32(ops[4:]), | ||
| } | ||
|
|
There was a problem hiding this comment.
maybe remove this blank line
aboch
reviewed
Jul 3, 2024
| if filter.Fd >= 0 { | ||
| return fmt.Errorf("only Ops or Fd can be specified on a BpfFilter") | ||
| } | ||
|
|
|
@stffabi please resolve the conflict and address a couple of minor comemnts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to use classic BPF programs to be applied to a BPF Filter, without the need to load a eBPF program.