Reset DNS - add a warning

[shoulders]

SYSTEM INFORMATION
OS type and version	Ubuntu Linux 22.04.4
Webmin version	2.111
Usermin version	2.010
Virtualmin version	7.10.0
Theme version	21.10
Package updates	92 package updates are available

background

• when I reset the DNS on virtual server it just immediately resets the DNS.
• when i clicked on the reset dns button on a sub-server whoes DNS was being controlled by the parent, virtualmin warned me it was going to reset the DNS. The changes showed it was going to reset the parent DNS (and I assume the sub-servers which was part of it.

the issue

no warning message for normal virtual servers about what was going to be changed.

solution

add the prompt indicating what is going to be changed for normal virtual servers rather than immediately carrying out the command.

related

#838 Reset DNS button should not be available on sub-servers when parent controls the DNS

[jcameron]

Do you think it would be useful to show what DNS records are going to be added or removed?

[shoulders]

On the sub server when I clicked the button it showed the records that were going to be removed, but to be honest I did not find that useful except that it showed me it was going to reset the parents zone so in this case it was.

Going forwards this 'bug' will not be an issue, so maybe a warning message will be fine.

Example message:

The DNS zone
can.example.com is going to be reset to default values as set by the relevant server template.

[jcameron]

Ok, this will be fixed in the next next Virtualmin release.

[shoulders]

SYSTEM INFORMATION
OS type and version	Ubuntu Linux 22.04.4
Webmin version	2.111
Usermin version	2.010
Virtualmin version	7.10.0
Theme version	21.10
Package updates	94 package updates are available

I made some changes to the default server template and then using chrome on my dev virtualmin server, when i clicked the DNS reset button I got the following warning which is great but as you can see I am still on 7.10.0.

Do you only get this warning if a change has been noticed by Virtualmin?

I then made a change in my developer template on the dns page and then went and reset the dns again but this time the button went straight to action

[iliajie]

Related #774 (comment).

[jcameron]

Yeah the warning is only shown if some records are expected to be removed. Otherwise it proceeds without any warning.