Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using the scale-value crate #15

Open
gilescope opened this issue Jun 13, 2022 · 2 comments
Open

Consider using the scale-value crate #15

gilescope opened this issue Jun 13, 2022 · 2 comments

Comments

@gilescope
Copy link

The Value type from the desub project has been factored out into it's own crate:

https://github.com/paritytech/scale-value

This may or may not be helpful to you.

@olanod
Copy link
Member

olanod commented Jun 16, 2022

Ohhh forking SCALES would have been nicer :(
I'll try it out and perhaps benchmark it to see if it fits our needs, I suppose a parity maintained library will always be more popular. Some features might still be needed like the serializer(JSON -> SCALE), WASM support and need to compare the lightweightness and no_std friendliness to see if it can work with libwallet for hardware wallets.

@gilescope
Copy link
Author

gilescope commented Oct 11, 2022 via email

olanod pushed a commit that referenced this issue Nov 16, 2023
add hashmap for subaccounts in wallet

Code review changes and serialization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants