Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing case (fixes Silicon issue #742) #730

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Added missing case (fixes Silicon issue #742) #730

merged 2 commits into from
Aug 14, 2023

Conversation

marcoeilers
Copy link
Contributor

No description provided.

jcp19
jcp19 approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@jcp19 jcp19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One-line fixes are great 😅 can we add the example from the bug report as a silver test?

@marcoeilers marcoeilers merged commit 501f1ec into master Aug 14, 2023
5 checks passed
@marcoeilers marcoeilers deleted the meilers_fix_silicon_742 branch August 14, 2023 18:22
@marcoeilers marcoeilers mentioned this pull request Aug 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcp19 jcp19 jcp19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcoeilers @jcp19