Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make simplifier preserve (lack of) well-definedness #609

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zgrannan
Copy link
Contributor

Currently, the simplifier converts an expression s[1] == s[1] to true; however, the original expression may not be well-defined (and Silicon / Carbon would raise an exception accordingly).

This PR makes the simplifier more conservative, such that it only simplifies expressions that are guaranteed (syntactically) to be well-defined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant