Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(AdtPlugin) fixes and regression tests for #581 #582

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Pointerbender
Copy link

The new ADT plugin did not handle result expressions in post-conditions yet properly. This PR is a patch to fix a couple of corner cases with additional regression tests.

@mschwerhoff
Copy link
Contributor

Thank you for investigating the issue. I assume the PR is WIP until a complete solution is found. If so, please mark the PR as such, so that it doesn't get merged accidentally, or code-reviewed prematurely.

@Pointerbender Pointerbender marked this pull request as draft May 30, 2022 08:13
@Pointerbender
Copy link
Author

I just converted this PR to draft. Although the work-around in this PR works, I suspect a better solution will come out of #581. It seems to be related to a problem in the transformer logic itself and the final fix is probably better addressed in that part of the code (hoping someone might look alongside to see what the issue is in the transformer, I didn't have much luck spotting it yet :) ). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants