Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub actions and fix release builds #1435

Merged
merged 6 commits into from
Aug 11, 2023
Merged

Update GitHub actions and fix release builds #1435

merged 6 commits into from
Aug 11, 2023

Conversation

vakaras
Copy link
Contributor

@vakaras vakaras commented Aug 4, 2023

Update GitHub actions to fix deprecation warnings.

@vakaras vakaras force-pushed the update-actions branch 4 times, most recently from 9711665 to d3427ff Compare August 4, 2023 19:50
@fpoli
Copy link
Member

fpoli commented Aug 11, 2023

Found it! The linker error seems to be due to rust-lang/rust#111888, because setting codegen-units = 1 fixes it 😄

@fpoli fpoli changed the title Update GitHub actions. Update GitHub actions and fix release builds Aug 11, 2023
@fpoli fpoli self-assigned this Aug 11, 2023
@fpoli fpoli enabled auto-merge August 11, 2023 07:57
.github/workflows/test.yml Outdated Show resolved Hide resolved
@fpoli
Copy link
Member

fpoli commented Aug 11, 2023

I'm not convinced we should keep the build-release job, because it raises the number of VMs used in parallel to 11 per CI run, and GitHub only provides a maximum of 20 parallel VMs across all projects of our organization.

I'll merge for the moment, but we should follow up on this.

@fpoli fpoli merged commit 3802482 into master Aug 11, 2023
20 checks passed
@fpoli fpoli deleted the update-actions branch August 11, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants