Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime/colors/README.txt may contain outdated information #264

Open
romainl opened this issue Jul 15, 2024 · 3 comments
Open

runtime/colors/README.txt may contain outdated information #264

romainl opened this issue Jul 15, 2024 · 3 comments

Comments

@romainl
Copy link
Collaborator

romainl commented Jul 15, 2024

For example, this line is not needed anymore and I'm not sure it ever was.

The suggested boilerplate should match the content of the colorschemes distributed with Vim.

@chrisbra
Copy link
Member

It is still used by default.vim. I think this warrants the line to be still there.

@romainl
Copy link
Collaborator Author

romainl commented Jul 15, 2024

That file contains instructions for how to write new colorschemes. How default is written is irrelevant.

@habamax
Copy link
Collaborator

habamax commented Jul 16, 2024

I think these 2 lines are redundant:

	highlight clear Normal
	set background&

for dual-background colorschemes in general. I am not talking about background autodetection being mostly wrong, but for the usual flow: user sets background to 'dark' or 'light' and expects colorscheme that supports it to act accordingly.

Here colorscheme is resetting background and will always use "detected" one, no matter what user wanted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants