From 7e039e57f7b524959c2f9951b0534b329500ef66 Mon Sep 17 00:00:00 2001
From: vibhatha <vibhatha@gmail.com>
Date: Thu, 18 Jan 2024 21:52:23 +0530
Subject: [PATCH] feat: initial test pending

---
 java/dev/checkstyle/checkstyle.xml | 19 ++++++++++---------
 java/maven/pom.xml                 |  2 +-
 java/pom.xml                       |  2 +-
 3 files changed, 12 insertions(+), 11 deletions(-)

diff --git a/java/dev/checkstyle/checkstyle.xml b/java/dev/checkstyle/checkstyle.xml
index c27f382ddda76..c8da63da60324 100644
--- a/java/dev/checkstyle/checkstyle.xml
+++ b/java/dev/checkstyle/checkstyle.xml
@@ -60,6 +60,11 @@
       <property name="eachLine" value="true"/>
     </module>
 
+    <module name="LineLength">
+        <property name="max" value="120"/>
+        <property name="ignorePattern" value="^package.*|^import.*|a href|href|http://|https://|ftp://"/>
+    </module>
+
     <module name="TreeWalker">
         <module name="OuterTypeFilename"/>
         <module name="IllegalTokenText">
@@ -72,10 +77,6 @@
             <property name="allowByTailComment" value="true"/>
             <property name="allowNonPrintableEscapes" value="true"/>
         </module>
-        <module name="LineLength">
-            <property name="max" value="120"/>
-            <property name="ignorePattern" value="^package.*|^import.*|a href|href|http://|https://|ftp://"/>
-        </module>
         <module name="OneTopLevelClass"/>
         <module name="NoLineWrap"/>
         <module name="EmptyBlock">
@@ -223,14 +224,14 @@
         <module name="JavadocMethod">
             <property name="scope" value="public"/>
             <property name="allowMissingParamTags" value="true"/>
-            <property name="allowMissingThrowsTags" value="true"/>
+<!--            <property name="allowMissingThrowsTags" value="true"/>-->
             <property name="allowMissingReturnTag" value="true"/>
-            <property name="minLineCount" value="2"/>
+<!--            <property name="minLineCount" value="2"/>-->
             <property name="allowedAnnotations" value="Override, Test"/>
-            <property name="allowThrowsTagsForSubclasses" value="true"/>
+<!--            <property name="allowThrowsTagsForSubclasses" value="true"/>-->
             <!-- This seems partially broken under JDK >= 9. -->
-            <property name="suppressLoadErrors" value="true"/>
-            <property name="ignoreMethodNamesRegex" value="main"/>
+<!--            <property name="suppressLoadErrors" value="true"/>-->
+<!--            <property name="ignoreMethodNamesRegex" value="main"/>-->
         </module>
         <module name="JavadocType">
             <property name="scope" value="public"/>
diff --git a/java/maven/pom.xml b/java/maven/pom.xml
index 3a88ec762e19c..7fdca7db7b8d8 100644
--- a/java/maven/pom.xml
+++ b/java/maven/pom.xml
@@ -235,7 +235,7 @@
           <dependency>
             <groupId>com.puppycrawl.tools</groupId>
             <artifactId>checkstyle</artifactId>
-            <version>8.19</version>
+            <version>8.29</version>
           </dependency>
           <dependency>
             <groupId>org.slf4j</groupId>
diff --git a/java/pom.xml b/java/pom.xml
index 3951f1c1bc8ed..4d3ba9370ed30 100644
--- a/java/pom.xml
+++ b/java/pom.xml
@@ -304,7 +304,7 @@
           <dependency>
             <groupId>com.puppycrawl.tools</groupId>
             <artifactId>checkstyle</artifactId>
-            <version>8.19</version>
+            <version>8.29</version>
           </dependency>
           <dependency>
             <groupId>org.slf4j</groupId>