Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] dynamic_macro_record_key_user doesn't get called on keypress #570

Open
kaine119 opened this issue Oct 11, 2023 · 0 comments
Open

[Bug] dynamic_macro_record_key_user doesn't get called on keypress #570

kaine119 opened this issue Oct 11, 2023 · 0 comments

Comments

@kaine119
Copy link
Contributor

See qmk/qmk_firmware#22250.

I implemented a dynamic_macro_record_key_user() hook, but it wasn't being called on every keypress when recording, as per the docs. Have filed a pull request for this bug against upstream qmk, should I file the same PR here too, or wait for changes to be merged from upstream? Thanks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kaine119