Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom network parameters #2

Open
Tracked by #1
vexy opened this issue Apr 10, 2024 · 0 comments · Fixed by #14
Open
Tracked by #1

Custom network parameters #2

vexy opened this issue Apr 10, 2024 · 0 comments · Fixed by #14
Assignees
@FilipKolakovic
Labels
core Vincoin core component
Milestone
Functional Vincoi...

Comments

@vexy
Copy link
Owner

vexy commented Apr 10, 2024 •
edited
Loading

Tasks needed for Vincoin network to be different than Bitcoin
@vexy vexy added the core Vincoin core component label Apr 10, 2024
@vexy vexy added this to the Functional Vincoin network milestone Apr 10, 2024
@vexy vexy mentioned this issue Apr 10, 2024
Open
3 tasks
FilipKolakovic added a commit that referenced this issue May 1, 2024
@FilipKolakovic
change port number #2 (chainparams.cpp)
089aadc
@vexy vexy linked a pull request May 1, 2024 that will close this issue
Feature: customize network parameters #14
Merged
FilipKolakovic added a commit that referenced this issue May 4, 2024
@FilipKolakovic
Rename bitcoin occurrences to vincoin in filenames #2
4f6c180
FilipKolakovic added a commit that referenced this issue May 16, 2024
@FilipKolakovic
change port number #2 (chainparams.cpp)
2045196
FilipKolakovic added a commit that referenced this issue May 16, 2024
@FilipKolakovic
Feature: customize network parameters (#14)
5fc0f4a 
* Change port number

* change port number #2 (chainparams.cpp)

* remove default seeding logic and seed nodes

* Change RPC port number

* Change Magic bytes and address prefix
@FilipKolakovic FilipKolakovic self-assigned this May 16, 2024
vexy pushed a commit that referenced this issue Aug 4, 2024
refactor: Use util::Split to avoid a harmless unsigned-integer-overflow
fac932b 
The previous commit added a test which would fail the
unsigned-integer-overflow sanitizer. The warning is harmless and can be
triggered on any commit, since the code was introduced.

For reference, the warning would happen when the separator `-` was not
present.

For example:

  GET /rest/getutxos/6a297bfa5cb8dd976ab0207a767d6cbfaa5e876f30081127ec8674c8c52b16c0_+1.json

would result in:

rest.cpp:792:77: runtime error: unsigned integer overflow: 18446744073709551615 + 1 cannot be represented in type 'size_type' (aka 'unsigned long')
    #0 0x55ad42c16931 in rest_getutxos(std::any const&, HTTPRequest*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&) src/rest.cpp:792:77
    #1 0x55ad4319e3c0 in std::function<bool (HTTPRequest*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&)>::operator()(HTTPRequest*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&) const /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/std_function.h:591:9
    #2 0x55ad4319e3c0 in HTTPWorkItem::operator()() src/httpserver.cpp:59:9
    #3 0x55ad431a3eea in WorkQueue<HTTPClosure>::Run() src/httpserver.cpp:114:13
    #4 0x55ad4318f961 in HTTPWorkQueueRun(WorkQueue<HTTPClosure>*, int) src/httpserver.cpp:403:12
    #5 0x7f078ebcbbb3  (/lib/x86_64-linux-gnu/libstdc++.so.6+0xeabb3) (BuildId: 40b9b0d17fdeebfb57331304da2b7f85e1396ef2)
    #6 0x55ad4277e01c in asan_thread_start(void*) asan_interceptors.cpp.o
    #7 0x7f078e840a93  (/lib/x86_64-linux-gnu/libc.so.6+0x9ca93) (BuildId: 08134323d00289185684a4cd177d202f39c2a5f3)
    #8 0x7f078e8cdc3b  (/lib/x86_64-linux-gnu/libc.so.6+0x129c3b) (BuildId: 08134323d00289185684a4cd177d202f39c2a5f3)

SUMMARY: UndefinedBehaviorSanitizer: unsigned-integer-overflow rest.cpp:792:77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FilipKolakovic FilipKolakovic

Labels
core Vincoin core component
Projects
None yet
Milestone
Functional Vincoin network
Development

Successfully merging a pull request may close this issue.

Feature: customize network parameters vexy/vincoin
2 participants
@vexy @FilipKolakovic