Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nebula Console Pod not use user defined ImagePullPolicy which configured in values.xml #526

Open
qian2009 opened this issue Sep 20, 2024 · 1 comment
Assignees

Comments

@qian2009
Copy link

I need to deploy nebula at a offline environment, but it's not easy because of the ImagePullPolicy is 'Always', no matter how I configure in the value.xml file.

Finally, I check the source code and found that the ImagePullPolicy of Nebula Console Pod was just hard coded:

	container := corev1.Container{
		Name:            "console",
		Image:           getConsoleImage(nc.Spec.Console),
		ImagePullPolicy: corev1.PullAlways,

I think the ImagePullPolicy should be specified in values.xml rather than hard coded
@MegaByte875
Copy link
Contributor

Thanks, I will fix it assp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants