-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a vert.x cluster option. #227
base: master
Are you sure you want to change the base?
Conversation
Need to write your IP address in the box. ex) options.setClusterHost("192.168.0.55");
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pipy201 thanks for the PR! A few changes are needed
@@ -47,8 +47,11 @@ | |||
|
|||
@PostConstruct | |||
void init() throws ExecutionException, InterruptedException { | |||
VertxOptions options = new VertxOptions() | |||
.setClusterManager(new HazelcastClusterManager(hazelcastInstance)); | |||
VertxOptions options = new VertxOptions() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update your IDE config to use 2 spaces instead of 4.
.setClusterManager(new HazelcastClusterManager(hazelcastInstance)); | ||
VertxOptions options = new VertxOptions() | ||
.setClusterManager(new HazelcastClusterManager(hazelcastInstance)) | ||
.setClustered(true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed
VertxOptions options = new VertxOptions() | ||
.setClusterManager(new HazelcastClusterManager(hazelcastInstance)) | ||
.setClustered(true) | ||
.setHAEnabled(true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed
.setClusterManager(new HazelcastClusterManager(hazelcastInstance)) | ||
.setClustered(true) | ||
.setHAEnabled(true) | ||
.setClusterHost("192.168.0.67");// Write your ip address numeric form |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can't do this otherwise no one can run the examples without modifying source. You could introduce a Spring config property for cluster host. If not set, setClusterHost
would not be called
@pipy201 any news on this one? |
Need to write your IP address.
ex) options.setClusterHost("192.168.0.55");