Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect sigterm handler causes false netsplits for docker swarm mode #324

Open
Pistro opened this issue Sep 14, 2022 · 1 comment
Open

Comments

@Pistro
Copy link

Pistro commented Sep 14, 2022

I seems that the sigterm handler for docker swarm does not execute the "vmq-admin cluster leave" command. Thus, whenever the swarm size is reduced (or the swarm code is updated and the IP adresses of the nodes changes), VerneMQ does not realize that the swarm nodes which went offline are not coming back, which causes it to act as if there were a netsplit.

If i look through the code of the "start_vernemq" script, it seems that nodes going offline in a docker swarm used to be handled correctly, but then there was some code refactoring, and now I think it only works for Kubernetes clusters.
If believe the bug was introduced in this commit:
da6c608

Thank you for looking at this issue!

@ioolkos
Copy link
Contributor

ioolkos commented Sep 15, 2022

@Pistro Thanks for reporting. Breaking Swarm compatibility certainly wasn't the idea... will look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants