Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added button availability and area recording buttons #5

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

prigorus
Copy link
Contributor

I have added all buttons that are available for are recording in the native web app. Availability is also added for all buttons so that they are only possible to click when the option is available.

I am not using a prefix so it would help for someone to check if this works okay. I am also not sure about the emergency button availability if it needs to be inverted or not.

@vermut
Copy link
Owner

vermut commented Jul 25, 2024

I liked the ability to press any button at any time, because I don't trust internal OM logic. But let me attempt to make this a beta release and see how it will sit with others.

@vermut vermut self-requested a review July 25, 2024 06:42
@prigorus
Copy link
Contributor Author

I liked the ability to press any button at any time, because I don't trust internal OM logic. But let me attempt to make this a beta release and see how it will sit with others.

For skipping areas, it's not really an issue if it's available. Although skip path is currently unavailable until that is fixed in ROS (which is in some way useful to show that it doesn't work). I like the availability for area recording since I can see that a command was accepted. I use only HA for area recording since it's more reliable than the native app when it disconnects (but I am only pushing the mower rather than driving it).

@vermut vermut merged commit ac93628 into vermut:master Aug 7, 2024
2 checks passed
@vermut
Copy link
Owner

vermut commented Aug 7, 2024

People report buttons not working completely

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants