Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

figure out what to do with dataset deletion errors for BQTestCase #6

Open
laurendukes opened this issue Jan 17, 2018 · 0 comments
Open

Comments

@laurendukes
Copy link
Collaborator

To make tests pass when there are problems with teardown, I added a broad exception catcher that just logs errors when teardowns fail. There are two issues with this:

(a) failed deletions mean that datasets will collect in the testing project
(b) if something's consistently failing it won't show up in the test logs unless the test happens to fail, since bazel suppresses all non-failing test logs

I don't really know what a good solution is so I'm filing this issue to deal with it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant