Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support customizing the variable when using each font #40

Open
2 tasks done
mririgoyen opened this issue Nov 1, 2023 · 2 comments
Open
2 tasks done

Support customizing the variable when using each font #40

mririgoyen opened this issue Nov 1, 2023 · 2 comments
Labels
bug Something isn't working triaged where: package The issue corresponds to the distribution package

Comments

@mririgoyen
Copy link

Font Name (Geist Sans/Geist Mono):

  • Geist Sans
  • Geist Mono

Description of the Issue:
Each font emits it's own variable, --font-geist-sans and --font-geist-mono. We would like to override those to something custom. In our case, we need them to be more generic, such as --font-headings.

Steps to Reproduce:

  1. Use the fonts.

Expected Behavior:
Including the font allows for manual overriding the variable.

Additional Context:
I understand I can manually use localFont and build up the configuration, this would be more of a convenience feature.

@mririgoyen mririgoyen added the bug Something isn't working label Nov 1, 2023
@JohnPhamous
Copy link
Contributor

Thanks for the feedback. We will improve the API for the fonts soon!

@SaadBazaz
Copy link

Exactly what I'm looking for too.

Perhaps can be used as a constructor as well, like other fonts?

const fontHeading = GeistSans({
  subsets: ["latin"],
 weights: [800],
  variable: "--font-heading",
})

@guidoferreyra guidoferreyra added the where: package The issue corresponds to the distribution package label Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triaged where: package The issue corresponds to the distribution package
Projects
None yet
Development

No branches or pull requests

4 participants