-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): Have Vector master
use main
of VRL
#21417
Conversation
So that nightly releases can you unreleased VRL changes for testing. This was requested by a user. I can see the usefulness to be able to validate VRL changes without having to build Vector. As part of the release, we'll switch it to the latest released version (which should be the same SHA). Signed-off-by: Jesse Szwedko <[email protected]>
Your preview site for the VRL Playground will be ready in a few minutes, please allow time for it to build. Heres your preview link: |
Your preview site for the Rust Doc will be ready in a few minutes, please allow time for it to build. Heres your preview link: |
Your preview site for the vector.dev will be ready in a few minutes, please allow time for it to build. Heres your preview link: |
.to_string(); | ||
( | ||
precise.clone(), | ||
format!("{}/tree/{precise}", vrl_source.url()), |
Check warning
Code scanning / check-spelling
Candidate Pattern Warning
Datadog ReportBranch report: ✅ 0 Failed, 7 Passed, 0 Skipped, 25.53s Total Time |
@@ -149,7 +149,7 @@ toml = { version = "0.8.19", default-features = false, features = ["display", "p | |||
tonic = { version = "0.11", default-features = false, features = ["transport", "codegen", "prost", "tls", "tls-roots", "gzip"] } | |||
tonic-build = { version = "0.11", default-features = false, features = ["transport", "prost"] } | |||
uuid = { version = "1.10.0", features = ["v4", "v7", "serde"] } | |||
vrl = { version = "0.19.0", features = ["arbitrary", "cli", "test", "test_framework"] } | |||
vrl = { git = "https://github.com/vectordotdev/vrl", branch = "main", features = ["arbitrary", "cli", "test", "test_framework"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have any mitigation for the following scenario?
- Vector builds successfully with the latest VRL main
- We merge a new commit that changes an interface in VRL
- Vector builds will fail until we update the code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version will still be locked so an update to VRL won't break the Vector build on master
. Instead, a PR opened by dependabot that bumps VRL to latest will fail at which point we can intervene to make the necessary Vector updates in the same PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Regression Detector ResultsRun ID: 70c3e404-c26f-47ec-95e7-5d7298065716 Metrics dashboard Baseline: 3b58618 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI | links |
---|---|---|---|---|---|
✅ | file_to_blackhole | egress throughput | +21.14 | [+13.44, +28.84] |
Fine details of change detection per experiment
perf | experiment | goal | Δ mean % | Δ mean % CI | links |
---|---|---|---|---|---|
✅ | file_to_blackhole | egress throughput | +21.14 | [+13.44, +28.84] | |
➖ | syslog_regex_logs2metric_ddmetrics | ingress throughput | +3.47 | [+3.32, +3.62] | |
➖ | otlp_http_to_blackhole | ingress throughput | +2.46 | [+2.33, +2.59] | |
➖ | datadog_agent_remap_datadog_logs | ingress throughput | +1.92 | [+1.72, +2.12] | |
➖ | datadog_agent_remap_datadog_logs_acks | ingress throughput | +1.88 | [+1.67, +2.09] | |
➖ | fluent_elasticsearch | ingress throughput | +1.22 | [+0.73, +1.71] | |
➖ | syslog_splunk_hec_logs | ingress throughput | +1.10 | [+1.00, +1.21] | |
➖ | datadog_agent_remap_blackhole | ingress throughput | +0.72 | [+0.59, +0.85] | |
➖ | http_to_http_acks | ingress throughput | +0.70 | [-0.53, +1.94] | |
➖ | datadog_agent_remap_blackhole_acks | ingress throughput | +0.69 | [+0.56, +0.81] | |
➖ | otlp_grpc_to_blackhole | ingress throughput | +0.62 | [+0.51, +0.73] | |
➖ | http_to_http_noack | ingress throughput | +0.14 | [+0.06, +0.21] | |
➖ | http_to_http_json | ingress throughput | +0.05 | [+0.00, +0.10] | |
➖ | http_to_s3 | ingress throughput | +0.04 | [-0.24, +0.31] | |
➖ | splunk_hec_to_splunk_hec_logs_noack | ingress throughput | +0.02 | [-0.08, +0.11] | |
➖ | splunk_hec_to_splunk_hec_logs_acks | ingress throughput | +0.01 | [-0.11, +0.12] | |
➖ | splunk_hec_indexer_ack_blackhole | ingress throughput | -0.01 | [-0.09, +0.07] | |
➖ | http_text_to_http_json | ingress throughput | -0.28 | [-0.39, -0.16] | |
➖ | http_elasticsearch | ingress throughput | -0.47 | [-0.69, -0.25] | |
➖ | socket_to_socket_blackhole | ingress throughput | -0.53 | [-0.59, -0.46] | |
➖ | syslog_loki | ingress throughput | -0.72 | [-0.81, -0.64] | |
➖ | splunk_hec_route_s3 | ingress throughput | -0.92 | [-1.26, -0.58] | |
➖ | syslog_log2metric_splunk_hec_metrics | ingress throughput | -1.04 | [-1.14, -0.94] | |
➖ | syslog_log2metric_tag_cardinality_limit_blackhole | ingress throughput | -2.11 | [-2.20, -2.02] | |
➖ | syslog_humio_logs | ingress throughput | -2.71 | [-2.81, -2.61] | |
➖ | syslog_log2metric_humio_metrics | ingress throughput | -2.86 | [-3.00, -2.72] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
FYI @johnhtodd I finally was able to follow up on this :) Nightly Vector releases should now be using latest VRL, generally. Dependabot will be keeping it up-to-date so it may lag by a commit or two at times. |
@jszwedko Great! Thanks. That will speed testing significantly. |
So that nightly releases can you unreleased VRL changes for testing. This was requested by a user. I can see the usefulness to be able to validate VRL changes without having to build Vector.
As part of the release, we'll switch it to the latest released version (which should be the same SHA).