Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the http crate to version 1.0.0 #19179

Open
10 of 13 tasks
bruceg opened this issue Nov 17, 2023 · 5 comments
Open
10 of 13 tasks

Upgrade the http crate to version 1.0.0 #19179

bruceg opened this issue Nov 17, 2023 · 5 comments
Assignees
Labels
dependencies Pull requests that update a dependency file domain: deps Anything related to Vector's dependencies type: tech debt A code change that does not add user value.

Comments

@bruceg
Copy link
Member

bruceg commented Nov 17, 2023

This requires updating several crates simultaneously, only some of which currently have updates to their http dependencies. I will update this issue as the dependency crates are bumped:

@pront
Copy link
Contributor

pront commented Dec 8, 2023

Seems like https://crates.io/crates/http-types and https://crates.io/crates/hyper-proxy are on the latest version.

Also, https://crates.io/crates/tokio-tungstenite (PR) is another crate that seems to affected by the http upgrade.

@bruceg
Copy link
Member Author

bruceg commented Dec 11, 2023

Yes, both http-types and hyper-proxy do not have a released version that upgrades their usage to http 1.0. So, we are using their latest versions, but upgrading the other crates without those breaks the build.

Agreed, at least part of the tokio-tungstenite breakage is caused by this issue. I'll add that to the list.

@bruceg
Copy link
Member Author

bruceg commented Jan 15, 2024

Note that hyper-proxy appears to be unmaintained, as the last commit was 3 years ago, which may require converting Vector to use hyper-proxy2 (link) or handling proxying manually.

@bruceg
Copy link
Member Author

bruceg commented Jan 15, 2024

Similarly, the last commit to http-types was 2 years ago, but replacing it will be more difficult as it is depended on by azure_core and wiremock.

@bruceg
Copy link
Member Author

bruceg commented Jul 9, 2024

tonic now has released an updated version for the http/hyper 1.0 upgrade.
https://github.com/hyperium/tonic/blob/master/CHANGELOG.md

That just leaves the two unmaintained crates, which will need to either be removed or forked and handled ourselves.

jszwedko added a commit that referenced this issue Oct 2, 2024
Since we can't upgrade to tonic v12 yet due to #19179.

Signed-off-by: Jesse Szwedko <[email protected]>
github-merge-queue bot pushed a commit that referenced this issue Oct 2, 2024
Since we can't upgrade to tonic v12 yet due to #19179.

Signed-off-by: Jesse Szwedko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file domain: deps Anything related to Vector's dependencies type: tech debt A code change that does not add user value.
Projects
None yet
Development

No branches or pull requests

2 participants