Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template renderer inf loop if it cannot remove an attribute from a node #396

Open
mandragorn opened this issue Jun 2, 2019 · 0 comments
Open

Template renderer inf loop if it cannot remove an attribute from a node #396

mandragorn opened this issue Jun 2, 2019 · 0 comments

Comments

@mandragorn
Copy link
Contributor

In IE it is possible to get a node that you cannot remove the attribute from (in my case it was a hidden input node and the value attribute couldn't be removed. The value had a very large value in it).

When this happens template renderer gets in an inf loop trying to remove the same attribute.
mandragorn pushed a commit to mandragorn/backbone-torso that referenced this issue Jun 2, 2019
vecnatechnologies#396: Bail if attr cannot be removed during render
0d17ca9
mandragorn pushed a commit to mandragorn/backbone-torso that referenced this issue Jun 2, 2019
vecnatechnologies#396: Build change
b4d3a69
mandragorn pushed a commit to mandragorn/backbone-torso that referenced this issue Jun 2, 2019
vecnatechnologies#396: Bail if attr cannot be removed during render
c4b144b
mandragorn pushed a commit to mandragorn/backbone-torso that referenced this issue Jun 2, 2019
vecnatechnologies#396: Bail if attr cannot be removed during render
6ac8648
mandragorn added a commit that referenced this issue Jun 2, 2019
@mandragorn
Merge pull request #397 from mandragorn/396
3600c3b 
#396: Bail if attr cannot be removed during render
mandragorn added a commit that referenced this issue Jun 2, 2019
@mandragorn
Merge pull request #398 from mandragorn/396-from-tag
27574ed 
#396: Bail if attr cannot be removed during render
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mandragorn