Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options for custom selectors. #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jasonfarrell
Copy link

This allows users to pass a selector for the tab content and any selector for tab links.
It keeps the defaults.

@vdw vdw added the enhancement label Jan 6, 2016
@jasonfarrell
Copy link
Author

I'm fixing the new conflicts now…

This allows users to pass a selector for the tab content and any selector for tab links.
It keeps the defaults.
@jasonfarrell
Copy link
Author

@vdw ready to be merged — if you agree with my changes!

@brandensilva
Copy link

brandensilva commented Sep 3, 2016

👍

Could really use targets classes so the tab list can be outside the scope of the tab contents.

somewhere else on the page

<div class="tab-list">
  <a href="overview">Overview</a>
  <a href="directions">Directions</a>
</div>

main content

<div class="tabs">
  <div class="tab" id="overview">Tab 1 Content</div>
  <div class="tab" id="directions">Tab 2 Content</div>
</div>

@jasonfarrell @vdw Any luck fixing those merge conflicts?

@flowdee
Copy link

flowdee commented Mar 30, 2017

This would be amazing! @vdw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants