Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.1.1.1 is considered as valid version #60

Open
obfischer opened this issue Sep 27, 2021 · 3 comments
Open

Version 1.1.1.1 is considered as valid version #60

obfischer opened this issue Sep 27, 2021 · 3 comments

Comments

@obfischer
Copy link

obfischer commented Sep 27, 2021

Version 3.10.0 considers the version 1.1.1.1 as valid semantic version number. According to the semantic versioning specification, the version core must consist ony of the major version, the minor version and the patch version. Please accept only valid semantic version numbers.

@piotrooo
Copy link

@obfischer if you are still interested, I've create active copy of the semver4j lib (https://github.com/semver4j/semver4j) and fix this issue in 1.0.1 version.

@obfischer
Copy link
Author

@piotrooo Yes, of course. I also thought about forking it. I will switch to your version.

@piotrooo
Copy link

@obfischer I have in plans to do a big refactor since 2.0.0.
I have in plans to address all (or most) issues from this lib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants