Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid Suffix #40

Open
amiel92 opened this issue Oct 31, 2019 · 2 comments
Open

Invalid Suffix #40

amiel92 opened this issue Oct 31, 2019 · 2 comments

Comments

@amiel92
Copy link

amiel92 commented Oct 31, 2019

Hi,

if i get the semantic versioning specification right (https://semver.org/#spec-item-9), the following versions sould not be valid:

Semver sv = new Semver("1.0.0-"); //Identifiers MUST NOT be empty
sv = new Semver("1.0.0-alpha..1"); //Identifiers MUST NOT be empty
sv = new Semver("1.0.0-001"); //Numeric identifiers MUST NOT include leading zeroes
sv = new Semver("1.0.0-äöü"); //Identifiers MUST comprise only ASCII alphanumerics and hyphen

@jankeesvanandel
Copy link

We also run into this issue. We had users enter 1.2.3. (so with a trailing dot) as a version in our application, causing issues downstream. I believe the TS is right and this is not a valid semver according to the specification.

@piotrooo
Copy link

@amiel92 if you are still interesting, I've made copy of this lib and fix bug reported by you. Look for version 2.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants