Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/release-please #62

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Feature/release-please #62

merged 3 commits into from
Sep 17, 2024

Conversation

vc1492a
Copy link
Owner

@vc1492a vc1492a commented Sep 4, 2024

@IroNEDR opening this pull request to review the setup of the release-please functionality as discussed in issue #61.

The workflow can only be fully tested once these code changes are integrated into the main branch as release-please is setup in .github/workflows/release-please to only draft releases in that branch, but I would like you to review the changes in the contribution guidelines and the setup for awareness and clarity.

@vc1492a vc1492a added documentation This issue relates to documentation review This issue is under review and will (hopefully) be closed soon labels Sep 4, 2024
@vc1492a vc1492a requested a review from IroNEDR September 4, 2024 23:17
@vc1492a vc1492a linked an issue Sep 5, 2024 that may be closed by this pull request
@vc1492a
Copy link
Owner Author

vc1492a commented Sep 11, 2024

@IroNEDR do you have a timeline on review?

Copy link
Collaborator

@IroNEDR IroNEDR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You can merge this. Sorry for the delayed response :)

@vc1492a vc1492a merged commit 63e7c8a into dev Sep 17, 2024
9 checks passed
@vc1492a vc1492a deleted the feature/release-please branch September 17, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This issue relates to documentation review This issue is under review and will (hopefully) be closed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate and leverage release-please for version tagging and releases
2 participants