From 33d8a53d4e4bc43edd8fe5fd8cfd9bc11db078c8 Mon Sep 17 00:00:00 2001 From: Nils Goroll Date: Thu, 12 Sep 2024 14:06:48 +0200 Subject: [PATCH] Coverity polish: 1605316 Overflowed constant Add assertion that we only process wait events which we have counted, anything else is a bug. --- bin/varnishd/waiter/cache_waiter_epoll.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/bin/varnishd/waiter/cache_waiter_epoll.c b/bin/varnishd/waiter/cache_waiter_epoll.c index 70b71c07d5..fb33c11996 100644 --- a/bin/varnishd/waiter/cache_waiter_epoll.c +++ b/bin/varnishd/waiter/cache_waiter_epoll.c @@ -105,6 +105,7 @@ vwe_thread(void *priv) } CHECK_OBJ_NOTNULL(wp, WAITED_MAGIC); AZ(epoll_ctl(vwe->epfd, EPOLL_CTL_DEL, wp->fd, NULL)); + AN(vwe->nwaited); vwe->nwaited--; AN(Wait_HeapDelete(w, wp)); Lck_Unlock(&vwe->mtx); @@ -138,6 +139,7 @@ vwe_thread(void *priv) continue; } AZ(epoll_ctl(vwe->epfd, EPOLL_CTL_DEL, wp->fd, NULL)); + AN(vwe->nwaited); vwe->nwaited--; if (ep->events & EPOLLIN) { if (ep->events & EPOLLRDHUP &&