Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quick preset editor must force values to be set on creation #2028

Open
stolpeo opened this issue Oct 14, 2024 · 0 comments
Open

quick preset editor must force values to be set on creation #2028

stolpeo opened this issue Oct 14, 2024 · 0 comments
Assignees

Comments

@stolpeo
Copy link
Contributor

stolpeo commented Oct 14, 2024

Currently the quick preset editor allows values to be null for the individual settings (inheritance, frequency, effect, etc). When a quick preset is selected in the filter form that does not set all values, the "empty" values are just ignored and the current setting is kept. This can lead to confusing and inconsistent results.

A viable solution is to enforce the values in the quick preset to be set:

  1. a new quick preset is created without any values. this means it must be allowed to have no settings
  2. do not show incomplete quick presets in the filter form
  3. show a warning in the filter form that a quick preset is not active unless all values are filled.
@stolpeo stolpeo self-assigned this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready
Development

No branches or pull requests

1 participant