Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding TypeScript support VanCone #189

Open
yahia-berashish opened this issue Dec 13, 2023 · 1 comment
Open

Adding TypeScript support VanCone #189

yahia-berashish opened this issue Dec 13, 2023 · 1 comment

Comments

@yahia-berashish
Copy link
Contributor

Hello again.
I will be trying to open a PR to add TypeScript support, but I don't have enough information about how the vanjs-core works, I tried to get some things done with ChatGPT, but I think I still need help from @b-rad-c on how the code functions and what types are expected to be passed and result from the code.

@b-rad-c
Copy link
Contributor

b-rad-c commented Dec 13, 2023

Awesome thanks! Could you close the pull request on this repository and open a PR on the ts-support branch of my repository?

I just pushed a new version last night that has contribution instructions in the README. I'm maintaining the project but it's hosted in the official VanJS repo which I don't have write permissions to. So the procedure is to open a PR on my repository, I'll approve/merge and then make a pull request upstream to the official VanJS repo.

The new version has some additional features/changes so we'll need to address that in your new ts file, if you have time to update it that'd be great, if not just push what you have right now and I'll update it. The changes are noted in the changelog in the readme file.

Thanks a lot for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants