-
Notifications
You must be signed in to change notification settings - Fork 0
/
batcher_test.go
236 lines (215 loc) · 5.67 KB
/
batcher_test.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
package batcher
import (
"context"
"errors"
"testing"
"time"
)
func TestNewBatcher(t *testing.T) {
for _, params := range []struct {
name string
commitFn CommitFunc[int, int]
opts []Option[int, int]
maxSize int
timeout time.Duration
mustPanic bool
}{
{
name: "nil commit func",
commitFn: nil,
mustPanic: true,
},
{
name: "negative max size",
commitFn: func(_ context.Context, _ []*Operation[int, int]) {},
opts: []Option[int, int]{
WithMaxSize[int, int](-1),
},
mustPanic: true,
},
{
name: "negative timeout",
commitFn: func(_ context.Context, _ []*Operation[int, int]) {},
opts: []Option[int, int]{
WithTimeout[int, int](-1 * time.Second),
},
mustPanic: true,
},
{
name: "unlimited size with no timeout",
commitFn: func(_ context.Context, _ []*Operation[int, int]) {},
opts: []Option[int, int]{
WithMaxSize[int, int](UnlimitedSize),
WithTimeout[int, int](NoTimeout),
},
mustPanic: true,
},
{
name: "unlimited size with no timeout (no option provided)",
commitFn: func(_ context.Context, _ []*Operation[int, int]) {},
opts: nil,
mustPanic: true,
},
{
name: "max size equals 10",
commitFn: func(_ context.Context, _ []*Operation[int, int]) {},
opts: []Option[int, int]{
WithMaxSize[int, int](10),
},
maxSize: 10,
timeout: NoTimeout,
},
{
name: "timeout equals 1s",
commitFn: func(_ context.Context, _ []*Operation[int, int]) {},
opts: []Option[int, int]{
WithTimeout[int, int](1 * time.Second),
},
maxSize: UnlimitedSize,
timeout: 1 * time.Second,
},
{
name: "max size equals 10 and timeout equals 1s",
commitFn: func(_ context.Context, _ []*Operation[int, int]) {},
opts: []Option[int, int]{
WithMaxSize[int, int](10),
WithTimeout[int, int](1 * time.Second),
},
maxSize: 10,
timeout: 1 * time.Second,
},
} {
t.Run(params.name, func(t *testing.T) {
var b *Batcher[int, int]
defer func() {
v := recover()
switch {
case params.mustPanic && v == nil:
t.Errorf("expected panic")
case !params.mustPanic && v != nil:
t.Errorf("unexpected panic: %v", v)
case !params.mustPanic && v == nil:
if b.maxSize != params.maxSize {
t.Errorf("unexpected max size: got %d, want %d", b.maxSize, params.maxSize)
}
if b.timeout != params.timeout {
t.Errorf("unexpected timeout: got %s, want %s", b.timeout, params.timeout)
}
}
}()
b = New(params.commitFn, params.opts...)
})
}
}
func TestBatcherSend(t *testing.T) {
for _, params := range []struct {
name string
err error
}{
{
name: "send value",
},
{
name: "send expires error",
err: context.DeadlineExceeded,
},
} {
t.Run(params.name, func(t *testing.T) {
ctx, cancel := context.WithTimeout(context.Background(), 1*time.Second)
defer cancel()
b := &Batcher[int, int]{
in: make(chan *Operation[int, int]),
}
if params.err == nil || !errors.Is(params.err, context.DeadlineExceeded) {
go func() {
<-b.in
}()
}
_, err := b.Send(ctx, 1)
switch {
case err == nil && params.err != nil:
t.Error("expected error")
case err != nil && params.err == nil:
t.Errorf("unexpected error: %v", err)
case err != nil && !errors.Is(err, params.err):
t.Errorf("unexpected error: got %v, want %v", err, params.err)
}
})
}
}
func TestBatcherBatch(t *testing.T) {
for _, params := range []struct {
name string
maxSize int
timeout time.Duration
}{
{
name: "max size equals 10 and no timeout",
maxSize: 10,
timeout: NoTimeout,
},
{
name: "unlimited size and timeout equals 1s",
maxSize: UnlimitedSize,
timeout: 1 * time.Second,
},
{
name: "max size equals 10 and timeout equals 1s",
maxSize: 10,
timeout: 1 * time.Second,
},
} {
t.Run(params.name, func(t *testing.T) {
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
countedTotalSize := 0
b := &Batcher[time.Time, time.Time]{
commitFn: func(_ context.Context, out []*Operation[time.Time, time.Time]) {
const dt = 100 * time.Millisecond
if len(out) == 0 {
t.Error("unfilled batch committed")
return
}
elapsed := time.Since(out[0].Value)
t.Logf("committed batch: len(out) = %d, elapsed = %s", len(out), elapsed)
switch {
case params.maxSize != UnlimitedSize && len(out) > params.maxSize:
t.Errorf("unexpected batch size: got %d, want at most %d", len(out), params.maxSize)
case params.timeout != NoTimeout && elapsed-dt > params.timeout:
t.Errorf("unexpected timeout: got %s, want at most %s⩲%s", elapsed, params.timeout, dt)
}
countedTotalSize += len(out)
},
maxSize: params.maxSize,
timeout: params.timeout,
in: make(chan *Operation[time.Time, time.Time]),
}
done := make(chan struct{})
go func() {
b.Batch(ctx)
close(done)
}()
totalSize := max(2*params.maxSize, 10)
greaterTimeout := params.timeout + 1*time.Second
for i := 0; i < totalSize; i++ {
switch i {
case 0:
// Simulate a delay to check that the batcher doesn't timeout while receiving the first operation.
time.Sleep(greaterTimeout)
case 1:
// Simulate a delay to check that the batcher commits after a timeout.
time.Sleep(greaterTimeout)
}
b.in <- &Operation[time.Time, time.Time]{
Value: time.Now(),
}
}
// Cancel the context to check that the batcher commits latent operations.
cancel()
<-done
if countedTotalSize != totalSize {
t.Errorf("unexpected counted total size: got %d, want %d", countedTotalSize, totalSize)
}
})
}
}