Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Please stop including tcmalloc.h via google/tcmalloc.h #1033

Open
alk opened this issue Sep 14, 2024 · 1 comment · May be fixed by #1039
Open

[BUG] Please stop including tcmalloc.h via google/tcmalloc.h #1033

alk opened this issue Sep 14, 2024 · 1 comment · May be fixed by #1039

Comments

@alk
Copy link

alk commented Sep 14, 2024

Describe the bug

google/tcmalloc.h location has been deprecated for > 10 years now. Please use gperftools/tcmalloc.h instead.

(Why am I posting this? Because I am about to make new gperftools release that removes this deprecated headers for good)
@madolson
Copy link
Member

Thanks for the heads up, I didn't even know we had this in the codebase. We should be able to easily migrate it (or delete it).

rjd15372 added a commit to rjd15372/valkey that referenced this issue Sep 17, 2024
@rjd15372
Changes tcmalloc.h header location (valkey-io#1033)
3f592c6 
This commit changes the `tcmalloc.h` header location from the
deprecated location `google/` to `gperftools/`.

*Why we're doing this now?*

The location `google/tcmalloc.h` has been deprecated for more
than 10 years in favor of `gperftools/tcmalloc.h`, and the
deprecated location will be removed in the next release of
gperftools.

Signed-off-by: Ricardo Dias <[email protected]>
rjd15372 added a commit to rjd15372/valkey that referenced this issue Sep 17, 2024
@rjd15372
Changes tcmalloc.h header location (valkey-io#1033)
acd74b7 
This commit changes the `tcmalloc.h` header location from the
deprecated location `google/` to `gperftools/`.

*Why we're doing this now?*

The location `google/tcmalloc.h` has been deprecated for more
than 10 years in favor of `gperftools/tcmalloc.h`, and the
deprecated location will be removed in the next release of
gperftools.

Signed-off-by: Ricardo Dias <[email protected]>
@enjoy-binbin enjoy-binbin linked a pull request Sep 17, 2024 that will close this issue
Changes tcmalloc.h header location (#1033) #1039
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changes tcmalloc.h header location (#1033) rjd15372/valkey
2 participants
@alk @madolson