Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sanitizers to CI and fix a found test issue #92

Merged
merged 3 commits into from
Sep 11, 2024

Conversation

bjosv
Copy link
Collaborator

@bjosv bjosv commented Sep 10, 2024

Update the CI workflow ubuntu:

  • Build using the now available GCC 14.
  • Build for Release only to use less CPU time.
  • Enable sanitizers.

The PR includes:

  • Fix global-buffer-overflow in client_test
    ..where the string length of "*1\r\n,3.14159265358979323846\r\n" is 29.

Use GCC 14 and build for Release only to use less CPU time.

Signed-off-by: Björn Svensson <[email protected]>
Signed-off-by: Björn Svensson <[email protected]>
The length of "*1\r\n,3.14159265358979323846\r\n" is 29.

Signed-off-by: Björn Svensson <[email protected]>
Copy link
Collaborator

@michael-grunder michael-grunder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on the 31 -> 29 multibulk

@bjosv bjosv merged commit 5f59243 into valkey-io:main Sep 11, 2024
31 checks passed
@bjosv bjosv deleted the sanitizers branch September 11, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants