Remove dict from user-facing API
#87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we want a stack allocated opaque struct, we need to expose the size but we can define it like struct valkeyClusterNodeIterator {
char opaque_data[NODE_ITERATOR_SIZE];
};With an appropriate comment about not relying on the size... |
zuiderkwast
reviewed
Sep 5, 2024
Signed-off-by: Björn Svensson <[email protected]>
Signed-off-by: Björn Svensson <[email protected]>
Signed-off-by: Björn Svensson <[email protected]>
bjosv
force-pushed
the
make-dict-private
branch
from
669a4b2
to
585e913
Compare
|
Not sure if this would be fragile when it comes to using it on new/other platforms with different packing of structs? |
michael-grunder
approved these changes
Sep 27, 2024
Co-authored-by: Michael Grunder <[email protected]> Signed-off-by: Björn Svensson <[email protected]>
zuiderkwast
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves
dict.hfrominclude/valkey/tosrc/which mainly affectsvalkeyClusterNodeIterator.By making the type
valkeyClusterNodeIteratoropaque we can hide its content and remove the exposure of thedictIterator.Fixes #44