Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small changes after formatting #78

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

mkmkme
Copy link
Contributor

@mkmkme mkmkme commented Aug 26, 2024

The first commit adds .git-blame-ignore-revs that lists the formatting commit so it would be omitted in git blame.

The second commit mentions clang-format version in README.

This file can be used for `blame.ignoreRevsFile` in the local clone of
the repo to omit the revisions listed there during `git blame`.

Signed-off-by: Mikhail Koviazin <[email protected]>
Copy link
Collaborator

@bjosv bjosv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We could have a CONTRIBUTING.md file, but since we have some info in the readme already, lets start here.

Copy link
Collaborator

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjosv bjosv merged commit c7e942b into valkey-io:main Aug 27, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants