Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for building a NuGet package #74

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

bjosv
Copy link
Collaborator

@bjosv bjosv commented Aug 20, 2024

Since we don't know if the valkey.targets works after the restructuring (if it's moved to the right place);
lets remove the support until a contributor needs it and has tested it.

Copy link
Collaborator

@michael-grunder michael-grunder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Doing this always crosses my mind when I see the file. A user will let us know if causes a problem.

@bjosv bjosv merged commit 2561649 into valkey-io:main Aug 21, 2024
41 checks passed
@bjosv bjosv deleted the remove-nuget branch August 21, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants