Don't initiate new connections during a cluster client disconnect (async API) #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Björn Svensson <[email protected]>
Signed-off-by: Björn Svensson <[email protected]>
Signed-off-by: Björn Svensson <[email protected]>
zuiderkwast
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
LGTM
Among the untouched lines, I noticed the below version definitions. We don't need those, do we? Valkey cluster and valkey is just one project with one version?
#define LIBVALKEYCLUSTER_MAJOR 0
#define LIBVALKEYCLUSTER_MINOR 14
#define LIBVALKEYCLUSTER_PATCH 0
#define LIBVALKEYCLUSTER_SONAME 0.14
Ah, great finding. Will remove. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a corresponding change to Nordix/hiredis-cluster#225 .