Cleanup of unused and superfluous code in src/vkutil.*
#41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Björn Svensson <[email protected]>
Signed-off-by: Björn Svensson <[email protected]>
Signed-off-by: Björn Svensson <[email protected]>
There are a mixed usage of own and standard assert, lets use standard from <assert.h> only. Signed-off-by: Björn Svensson <[email protected]>
|
Failing jobs? |
Signed-off-by: Björn Svensson <[email protected]>
Yes, seem to be some issue with windows that needs to be corrected. CentOS fails due to some install server |
Signed-off-by: Björn Svensson <[email protected]>
|
CentOS 7 is EOL. We should drop it. In Valkey we switched to some other old distro that we can use as the oldest supported system, some version of AlmaLinux IIRC. Regarding clang-format, are we using a too old version (13)? In Valkey we use version 18 to make it understand our conventions and config file. Not sure if this is the problem. |
|
Yes, we should replace CentoOS 7 and run clang-tidy on everything, I has never passed in libvalkey after the merge. |
michael-grunder
pushed a commit
to michael-grunder/libvalkey
that referenced
this pull request
Aug 1, 2024
- Remove unused code in `src/vkutil.*` - Remove macro `NOT_REACHED()`. - Remove function `vk_valid_port()`. - Remove own assert macro in cluster code. We have a mixed usage of own and standard assert. Lets use standard from <assert.h> only. Signed-off-by: Björn Svensson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/vkutil.*NOT_REACHED().vk_valid_port().We have a mixed usage of own and standard assert. Lets use standard from <assert.h> only.