Move remaining tests and build/run all legacy tests using CMake #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Björn Svensson <[email protected]>
Builds the non-cluster and all cluster tests via CMake, and run them via ctest. Example: mkdir build && cd build cmake -DENABLE_SSL=ON -DENABLE_IPV6_TESTS=ON .. make make test Signed-off-by: Björn Svensson <[email protected]>
Signed-off-by: Björn Svensson <[email protected]>
|
Ouch, I couldn't add the binary I had to set the outputname like |
Signed-off-by: Björn Svensson <[email protected]>
|
Naming suggestions for the binary are welcomed, naming is the hard part :) |
client_test works for me. It is mostly what those tests are doing. |
Signed-off-by: Björn Svensson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the remaining tests, i.e. the cluster tests, to the new project structure
and enables building and running all tests using CMake.
The cluster tests are a bit more complex to build and run than the non-cluster,
so currently the repo provided Makefile will only build the non-cluster tests.
This can probably be improved in the near future.
The legacy CMake options
ENABLE_SSL_TESTSandENABLE_ASYNC_TESTSare removed.This is now instead controlled by the build option
ENABLE_SSLand iflibeventis available.Closes #12