Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create cluster nodes dict and request list when initiating valkeyClusterContext #123

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Create cluster nodes dict and request list when initiating valkeyClusterContext #123

merged 2 commits into from
Oct 23, 2024

Conversation

bjosv
Copy link
Collaborator

@bjosv bjosv commented Oct 22, 2024

It simplifies the code a bit when these are allocated at context initiation.

zuiderkwast
zuiderkwast approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. We never free it except in the release function, so there is no chance it can ever be NULL now? I didn't check that OOM test suite with the hard-coded numbers.

@bjosv
Copy link
Collaborator Author

bjosv commented Oct 23, 2024

We never free it except in the release function, so there is no chance it can ever be NULL now?

Exactly, we only free in the release function.

@bjosv bjosv merged commit c95220a into valkey-io:main Oct 23, 2024
43 checks passed
@bjosv bjosv deleted the allocate-at-cluster-init branch October 23, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zuiderkwast zuiderkwast zuiderkwast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjosv @zuiderkwast