Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't expose internal functions in .so file #45

Open
zuiderkwast opened this issue Jul 3, 2024 · 0 comments
Open

Don't expose internal functions in .so file #45

zuiderkwast opened this issue Jul 3, 2024 · 0 comments

Comments

@zuiderkwast
Copy link
Collaborator

To avoid name collisions when linking projects with other versions of dict, sds, etc. we shouldn't expose these functions in the .so file.

We can compile with -fvisibility=hidden and explicitly add __attribute__((visibility("default"))) to the exported functions. It's explained in https://stackoverflow.com/a/4466766/975856.

(Related to #44.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant