You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now, we declare valkeyContext, valkeyAsyncContext, valkeyClusterContext, and valkeyAsyncClusterContext in our public headers, exposing their memory layout.
This makes it a lot harder to make changes to them without breaking the ABI contract and therefore having to bump the SONAME.
Users have to migrate to this project anyway, at least the renaming parts. There are other changes too. We should collect all these changes for release notes and migration guide.
Right now, we declare
valkeyContext
,valkeyAsyncContext
,valkeyClusterContext
, andvalkeyAsyncClusterContext
in our public headers, exposing their memory layout.This makes it a lot harder to make changes to them without breaking the ABI contract and therefore having to bump the SONAME.
We could switch to simply defining:
in our public headers, and declare the actual struct internally in a private header.
The only real downside is that it might break code for users who are directly accessing struct members. Personally, I can live with that 😄.
@bjosv @zuiderkwast What does everybody think?
The text was updated successfully, but these errors were encountered: