Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tests of parsing CLUSTER NODES response #33

Closed
bjosv opened this issue Jun 27, 2024 · 0 comments · Fixed by #112
Closed

Improve tests of parsing CLUSTER NODES response #33

bjosv opened this issue Jun 27, 2024 · 0 comments · Fixed by #112

Comments

@bjosv
Copy link
Collaborator

bjosv commented Jun 27, 2024

Add tests to cover slot map updates using CLUSTER NODES, but with special slot entries.

Some existing tests are:
https://github.com/valkey-io/libvalkey/blob/main/tests/scripts/moved-redirect-using-cluster-nodes-test.sh
https://github.com/valkey-io/libvalkey/blob/main/tests/scripts/connect-error-using-cluster-nodes-test.sh
https://github.com/valkey-io/libvalkey/blob/main/tests/scripts/moved-redirect-using-cluster-nodes-test.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add unit tests for CLUSTER NODES parsing bjosv/libvalkey
1 participant
@bjosv