Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move cluster code to src/ #14

Closed
zuiderkwast opened this issue Jun 18, 2024 · 6 comments · Fixed by #15
Closed

Move cluster code to src/ #14

zuiderkwast opened this issue Jun 18, 2024 · 6 comments · Fixed by #15
Assignees
@bjosv
Milestone
Libvalkey 1.0

Comments

@zuiderkwast
Copy link
Collaborator

zuiderkwast commented Jun 18, 2024 •
edited
Loading

No description provided.

@zuiderkwast zuiderkwast added this to the Libvalkey 1.0 milestone Jun 18, 2024
@zuiderkwast zuiderkwast changed the title Move code to src/ Move code to src/ Jun 18, 2024
@zuiderkwast zuiderkwast changed the title Move code to src/ Move cluster code to src/ Jun 19, 2024
@mkmkme
Copy link
Contributor

mkmkme commented Jun 19, 2024

Could you assign it to me please?

@mkmkme
Copy link
Contributor

mkmkme commented Jun 19, 2024

I think this, #16 and #12 can be done within one PR

@bjosv
Copy link
Collaborator

bjosv commented Jun 19, 2024

I would be happy if we could merge the changes we have in the renaming branch first before we move.
What do you think?

@mkmkme
Copy link
Contributor

mkmkme commented Jun 19, 2024

Sure thing! I asked for that just to keep track of tasks in the backlog :)

@zuiderkwast
Copy link
Collaborator Author

@mkmkme Let's create some issues for things you found in #15 that would be good to fix later.

@michael-grunder michael-grunder mentioned this issue Jun 21, 2024
Closed
@bjosv bjosv linked a pull request Jun 25, 2024 that will close this issue
Rebranding of code in libvalkeycluster #15
Merged
@bjosv
Copy link
Collaborator

bjosv commented Jun 25, 2024

Closed by #15

@bjosv bjosv closed this as completed Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bjosv bjosv

Labels
None yet
Projects
None yet
Milestone
Libvalkey 1.0
Development

Successfully merging a pull request may close this issue.

Rebranding of code in libvalkeycluster bjosv/libvalkey
3 participants
@zuiderkwast @mkmkme @bjosv