Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pep8 non-compliance and minor bugs. #106

Open
2 tasks
ledm opened this issue Aug 9, 2023 · 2 comments · May be fixed by #107
Open
2 tasks

Pep8 non-compliance and minor bugs. #106

ledm opened this issue Aug 9, 2023 · 2 comments · May be fixed by #107

Comments

@ledm
Copy link
Collaborator

ledm commented Aug 9, 2023 •
edited
Loading

Today, while working on PR #102, I've noticed several issues with bgcval2. Stuff like arguments that do nothing, things that are imported but never used, and some pep8 non-compliance. It would be nice to make it pretty.

Also, I've discovered the pycharm community python IDE today, so I might try to use that to generate some comments, and clean things up a bit.

Edit:
Files that I've run over:

  • bgcval2_make_report.py
  • analysis_compare.py

Wider issues this has uncovered:
@ledm
Copy link
Collaborator Author

ledm commented Aug 10, 2023

pycharm is finding so many ways to improve my old code. Lots of stuff like:

  • code alignment
  • incorrect capitals in file declarations
  • incorrect ordering of imports

@ledm
Copy link
Collaborator Author

ledm commented Aug 10, 2023

Working on this here:
https://github.com/valeriupredoi/bgcval2/tree/pep8_linting

@ledm ledm linked a pull request Aug 10, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pep8 linting valeriupredoi/bgcval2
1 participant
@ledm