-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@types in peerDeps #119
Comments
Sadly that's a general problem with TypeScript packages depending on If I put it in We depend on markdown-it-anchor/types/index.d.ts Lines 1 to 3 in 8918e4e
But it's also correct that if I put it in We would need to introduce a new kind of dependency in the ecosystem, e.g. This is documented here and discussed here and here I really wish there was another way! Let me know if you find anything on that :) |
If people want types, they want type for both
|
currently,
@types/markdown-it
was marked as a peerDependency, however in production mode,@types
shouldn't be installed, and package manager throws a peerDep missing warning.I think
"@types/markdown-it": "*"
should be placed into devDeps, and package managers would automatically choose which version to install (always reuse existing@types/markdown-it
installed by outer project first if possible, and in this case, all versions are compatible)The text was updated successfully, but these errors were encountered: