From 3c2792a0ddb9b162057f029ec856f0592f36a095 Mon Sep 17 00:00:00 2001 From: Andrea Valassi Date: Thu, 19 Sep 2024 18:08:02 +0300 Subject: [PATCH] [amd] in gq_ttq.mad and CODEGEN, work around the memory access crash #806 for HIPCC by disabling hipcc -O3, but keep -O2 (better than -O0) The test now still succeeds! ./check_hip.exe -p 1 8 1 --- .../madgraph/iolibs/template_files/gpu/cudacpp.mk | 2 +- epochX/cudacpp/gq_ttq.mad/SubProcesses/cudacpp.mk | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/epochX/cudacpp/CODEGEN/PLUGIN/CUDACPP_SA_OUTPUT/madgraph/iolibs/template_files/gpu/cudacpp.mk b/epochX/cudacpp/CODEGEN/PLUGIN/CUDACPP_SA_OUTPUT/madgraph/iolibs/template_files/gpu/cudacpp.mk index 27fc5a9d6..383b7292e 100644 --- a/epochX/cudacpp/CODEGEN/PLUGIN/CUDACPP_SA_OUTPUT/madgraph/iolibs/template_files/gpu/cudacpp.mk +++ b/epochX/cudacpp/CODEGEN/PLUGIN/CUDACPP_SA_OUTPUT/madgraph/iolibs/template_files/gpu/cudacpp.mk @@ -236,7 +236,7 @@ else ifeq ($(BACKEND),hip) GPUSUFFIX = hip # Optimization flags - override OPTFLAGS = -O0 # work around "Memory access fault" in gq_ttq for HIP #806: disable hipcc optimizations + override OPTFLAGS = -O2 # work around "Memory access fault" in gq_ttq for HIP #806: disable hipcc -O3 optimizations GPUFLAGS = $(foreach opt, $(OPTFLAGS), $(XCOMPILERFLAG) $(opt)) # DEBUG FLAGS (for #806: see https://hackmd.io/@gmarkoma/lumi_finland) diff --git a/epochX/cudacpp/gq_ttq.mad/SubProcesses/cudacpp.mk b/epochX/cudacpp/gq_ttq.mad/SubProcesses/cudacpp.mk index 4977dca38..20d8ded71 100644 --- a/epochX/cudacpp/gq_ttq.mad/SubProcesses/cudacpp.mk +++ b/epochX/cudacpp/gq_ttq.mad/SubProcesses/cudacpp.mk @@ -236,7 +236,7 @@ else ifeq ($(BACKEND),hip) GPUSUFFIX = hip # Optimization flags - override OPTFLAGS = -O0 # work around "Memory access fault" in gq_ttq for HIP #806: disable hipcc optimizations + override OPTFLAGS = -O2 # work around "Memory access fault" in gq_ttq for HIP #806: disable hipcc -O3 optimizations GPUFLAGS = $(foreach opt, $(OPTFLAGS), $(XCOMPILERFLAG) $(opt)) # DEBUG FLAGS (for #806: see https://hackmd.io/@gmarkoma/lumi_finland)